Repository navigation
Support Python >= 3.10 and make heavy dependencies optional (v1.4.0) - #206
Merged
Merged
Conversation
bifti 0.3.1 supports Python 3.10, so the requirement is relaxed from >= 3.12 to >= 3.10. Tested in fresh venvs on Python 3.10 - 3.15. - replace typing.Self (3.11+) with a string annotation - bump bifti to >= 0.3.1 and declare numpy, which is imported directly - add tested minimum versions: nibabel >= 5.2, numpy >= 1.22 - move scikit-image and torchkbnufft, which MRzeroCore never imports, to the new `playground` extra - move ismrmrd to the new `mrd` extra (>= 1.14.1, older versions break with current xsdata). Its h5py dependency has no wheels for some environments, e.g. Python 3.15. ismrmrd is imported lazily, so `import MRzeroCore` works without it and sig_to_mrd raises an ImportError that names the extra. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
J-Endres
force-pushed
the
relax-python-requirements
branch
from
November 11, 2026 10:21
e8635a8 to
da9e847
Compare
Simulation test: main (before) vs. this PR (after)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.











Relaxes the install requirements so MRzeroCore can be installed in more environments.
bifti0.3.1 now supports Python 3.10, so we can go back from>=3.12to>=3.10.Changes
>=3.10(was>=3.12). The only newer feature in our code wastyping.Selfintissue_dict.py; it is now a string annotation.bifti>=0.3.1.numpyis now declared as a dependency (it is imported everywhere). New minimum versions:nibabel>=5.2,numpy>=1.22.playgroundextra:scikit-imageandtorchkbnufftare no longer installed by default, because MRzeroCore never imports them. The notebooks already installtorchkbnufftthemselves.mrdextra:ismrmrd>=1.14.1is only needed forsig_to_mrd. Itsh5pydependency has no wheels for some environments (e.g. Python 3.15) and otherwise has to be built against system HDF5.ismrmrdis imported lazily:import MRzeroCoreworks without it, andsig_to_mrdraises anImportErrorthat namespip install mrzerocore[mrd]. The only notebook that usessig_to_mrdalready runspip install ismrmrd, and so does the playground CI.Testing
A smoke test in fresh uv venvs, using the abi3 wheel built from this branch. It writes a .seq with pypulseq, imports it with
pulseq_rsandpydisseqt, saves and reloads aTissueDictvia bifti, simulates, runsreco_adjoint,util.simulate,sig_to_mrdandpulseq_plot.pip install mrzerocoresig_to_mrdraises the expected ImportError)[mrd][playground]Known issues (not changed here)
Unsupported pulseq file version: 1.5.0), and has no cp315 wheel (it builds from source if Rust is installed). The defaultpulseq_rsbackend is not affected.sig_to_mrdneeds pypulseq >= 1.4 (it usesseq.definitions).🤖 Generated with Claude Code